Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug](x/simulation): Transactions run after FinalizeBlock in v0.50.x #22393

Open
1 task done
facundomedica opened this issue Oct 29, 2024 · 0 comments · May be fixed by #23382
Open
1 task done

[Bug](x/simulation): Transactions run after FinalizeBlock in v0.50.x #22393

facundomedica opened this issue Oct 29, 2024 · 0 comments · May be fixed by #23382
Assignees
@ziscky
Labels
C:baseapp T:Bug

Comments

@facundomedica
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Here: https://github.com/cosmos/cosmos-sdk/blob/release/v0.50.x/x/simulation/simulate.go#L188

We run FinalizeBlock before running operations, this is a problem if a module expects to do work on EndBlock using data from transactions executed in the same block.

Cosmos SDK Version

v0.50.x

How to reproduce?

No response
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Oct 29, 2024
@ziscky ziscky self-assigned this Jan 13, 2025
@ziscky ziscky linked a pull request Jan 14, 2025 that will close this issue
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ziscky ziscky

Labels
C:baseapp T:Bug
Projects
Cosmos-SDK
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(x/simulation): finalize block after operations cosmos/cosmos-sdk
3 participants
@ziscky @facundomedica @julienrbrt