A confusion about no need to execute IncrementSequenceDecorator on RecheckTX

[shaneing]

cosmos-sdk/x/auth/ante/sigverify.go

Line 313 in f9f92f2

// there is no need to execute IncrementSequenceDecorator on RecheckTX since

The implementation of IncrementSequenceDecorator seems to be no relevant code to skip increasing sequence when rechecking tx. However, It works great. I don't quite understand the logic here. Could anyone tell me?

In addition, the implementation of DeductFeeDecorator has the same confusion. Will it deduct coins from the account repeatedly?

[alexanderbez]

There isn't a need to bump the nonce or deduct fees once CheckTx has executed and thus the tx has been added to the mempool. Is this what you mean?

Or are you saying the godoc is out of date and incorrect?

EDIT: It does seem like the godoc is out of date hmmm...not sure if there is a need for a discussion thread. We can just open a PR if you're up for it :)

[shaneing]

Sorry, I am new to cosmos SDK. But I have understood the relevant code today and opened a PR to correct it.