Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper way to upgrade Satis #825

Open
WilliamDEdwards opened this issue Apr 10, 2024 · 6 comments
Open

Proper way to upgrade Satis #825

WilliamDEdwards opened this issue Apr 10, 2024 · 6 comments

Comments

@WilliamDEdwards
Copy link
Contributor

WilliamDEdwards commented Apr 10, 2024

The README says that Satis should be installed using composer create-project composer/satis:dev-main.

It then says that updating is done with: git pull && composer install

But when using composer create-project, git pull won't work... After all, there's no Git repository to pull.

The documentation at https://getcomposer.org/doc/articles/handling-private-packages.md#satis says that Satis can be installed using Git, too ("You can get it from GitHub or install via CLI").

This implies that there are two supported installation methods (Git, and CLI with composer create-project), while the README mentions (only) one for install, and the other for updating.

So, there is at least a documentation issue here. But more importantly: what is the proper way to upgrade Satis when installed using composer create-project?

@alcohol
Copy link
Member

alcohol commented Apr 11, 2024

The create-project example should probably include the --keep-vcs flag.

@GromNaN
Copy link
Contributor

GromNaN commented Apr 11, 2024

I've always preferred to have a project with composer/satis as a dependency. It lets you commit the configuration inside and use composer update to update it.

@WilliamDEdwards
Copy link
Contributor Author

Which installation method is recommended?

@alcohol
Copy link
Member

alcohol commented Apr 12, 2024

Whichever works best for you. 🤷 It is also a matter of personal preference. I like to use the Docker container.

@WilliamDEdwards
Copy link
Contributor Author

OK, then I’ll go for the method with a documented upgrade path.

I do think the documentation should be corrected, and users should be guided in picking an installation method, as most (if not all) users don’t really care.

@WilliamDEdwards
Copy link
Contributor Author

The create-project example should probably include the --keep-vcs flag.

I see this was done in 8dd9ab3. (It would have been handy to reference the issue.)

I also now see that the command on https://getcomposer.org/doc/articles/handling-private-packages.md:

php composer.phar create-project composer/satis --stability=dev --keep-vcs

... is not in sync with the one in this repository's README:

composer create-project --keep-vcs composer/satis:dev-main

I also believe --no-dev should be added.

I will create PRs to address both points.

WilliamDEdwards added a commit to WilliamDEdwards/satis that referenced this issue Apr 13, 2024
WilliamDEdwards added a commit to WilliamDEdwards/composer that referenced this issue Apr 13, 2024
…ently out of sync. This change fixes that, and prevent this from happening again. Relates to composer/satis#825
Seldaek pushed a commit to composer/composer that referenced this issue Apr 15, 2024
…ently out of sync. This change fixes that, and prevent this from happening again. Relates to composer/satis#825 (#11931)
alcohol pushed a commit to WilliamDEdwards/satis that referenced this issue May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants