-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not using this
context so much
#67
Comments
+1 i prefer doing |
+1 |
i'm fine with this change, but is removing it and having it just be |
yeah we've inherited a few bad things from jquery, parity is nice when it's a non-wtf thing, but I'd rather ditch the weird sides of jquery so people don't think this lib is supposed to maintain parity |
i'm not a fan of relying on
this
inside iterators because it feels really magicky, and i think its one of the bad parts of jquery.for some of the cases, it's already duplication, so we could easily just invoke the functions directly and let it be
window
like normalfor other cases, i'd propose a signature of
el, i, list
if we decide thatel
is the default people want. otherwiselist, el, i
if we think thatlist
is more frequentwhat do you guys think? open to suggestions, just feels really bad doing
this.hasClass
insidefilter
and suchThe text was updated successfully, but these errors were encountered: