Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CY-6602] StandardRB (for Rubocop) Support? #404

Open
berniechiu opened this issue Nov 4, 2022 · 5 comments
Open

[CY-6602] StandardRB (for Rubocop) Support? #404

berniechiu opened this issue Nov 4, 2022 · 5 comments
Labels
jira-issue Issue tracked on JIRA

Comments

@berniechiu
Copy link

berniechiu commented Nov 4, 2022

Hi Codacy Team,

Thanks for the nice platform.

codacy-rubocop/Gemfile

Lines 20 to 28 in 99f2321

#Rubocop official modules
gem "rubocop-performance"
gem "rubocop-rails"
gem "rubocop-rake"
gem "rubocop-rspec"
gem "rubocop-sorbet"
gem "rubocop-shopify"
gem "rubocop-graphql"
gem 'rubocop-thread_safety', require: false

Could we add standardrb in Gemfile so that we could include it in the standard Rubocop YAML .rubocop.yml like:

#=> .rubocop.yml
require: standard

inherit_gem:
  standard: config/base.yml

REF: https://github.com/testdouble/standard#usage-via-rubocop

Thanks a lot!

@github-actions github-actions bot added the jira-issue Issue tracked on JIRA label Nov 4, 2022
@github-actions github-actions bot changed the title StandardRB Support? [CY-6602] StandardRB Support? Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Internal ticket created : CY-6602

@berniechiu berniechiu changed the title [CY-6602] StandardRB Support? [CY-6602] StandardRB (for Rubocop) Support? Nov 4, 2022
@DMarinhoCodacy
Copy link
Contributor

Hello @berniechiu
We already added the Standard gem.
Thanks,
David Marinho

@berniechiu
Copy link
Author

Hi @DMarinhoCodacy, it still doesn't work at the moment?

Codacy Rubocop Error

@DMarinhoCodacy
Copy link
Contributor

Hey @berniechiu
What is the name of the repository?

@berniechiu
Copy link
Author

Hi @DMarinhoCodacy, this is our private repository. However, if I have some free time in the next few days, I'll set up a public repository.

In the meantime, you're welcome to set up Rubocop from your team for testing.

Our config is fairly simple TBH

require:
  - rubocop-performance
  - rubocop-rails
  - standard

inherit_gem:
  standard: config/base.yml

AllCops:
  # Prevent RuboCop from exploding when it finds an older-than-3.0 .ruby-version
  TargetRubyVersion: 3.2
  NewCops: enable
  Exclude: []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-issue Issue tracked on JIRA
Projects
None yet
Development

No branches or pull requests

2 participants