Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable InferBear #2816

Closed
jayvdb opened this issue Dec 7, 2018 · 9 comments
Closed

Disable InferBear #2816

jayvdb opened this issue Dec 7, 2018 · 9 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Dec 7, 2018

Due to #2664 completely failing now, a quick workaround is to disable the opam & infer, so that travis CI doesnt try to set up the pre-reqs, and so that the coverage is still 100%

@sladyn98
Copy link

sladyn98 commented Dec 7, 2018

One possible way would be:

  1. Remove opam under packages in the travis.yml so that i does not build.
  2. Remove .ci/deps.opam.sh under before_install.
  3. Remove - ~/infer-linux64-v$INFER_VERSION Under installed linters which would thereby make the path redundant.Correct me if i am wrong on this one.

@jayvdb
Copy link
Member Author

jayvdb commented Dec 7, 2018

That will fail the 100% coverage requirement.

@sladyn98
Copy link

sladyn98 commented Dec 7, 2018

Would adding them in the omit section of setup.cfg be a step in the right direction.Because then travis would not consider them for the test coverage.

@jayvdb
Copy link
Member Author

jayvdb commented Dec 7, 2018

setup.cfg is a generated file.

@sladyn98
Copy link

sladyn98 commented Dec 7, 2018

Executing Step 2 in the above comment would be one step taken in the right direction according to me.Because that is where the error is.

@jayvdb
Copy link
Member Author

jayvdb commented Dec 7, 2018

You need to have green CI. Otherwise we have another error.

@sladyn98
Copy link

sladyn98 commented Dec 7, 2018

Should I try submitting a PR and checking or should I try it locally.

@jayvdb
Copy link
Member Author

jayvdb commented Dec 7, 2018

You havent indicated you know how to solve the 100% coverage part of the problem mentioned as part of this issue.

Until you know how to solve this problem properly, I am not assigning it to you.

@sladyn98
Copy link

sladyn98 commented Dec 7, 2018

Hey @jayvdb, I googled a bit and i found this ocaml/dune#567. It be a problem with the broken ocaml version.

@jayvdb jayvdb self-assigned this Dec 16, 2018
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Dec 16, 2018
As InferBear is now disabled, the Python 3.6 builds work.

Related to coala#2664
Related to coala#2816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants