Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT CLOSE] Typo error found during the translation #441

Open
majinghe opened this issue Dec 16, 2020 · 2 comments
Open

[DO NOT CLOSE] Typo error found during the translation #441

majinghe opened this issue Dec 16, 2020 · 2 comments

Comments

@majinghe
Copy link

majinghe commented Dec 16, 2020

This issue is used to record the typo error found during the translation, once the translation is done, will open an issue to upstream community to confirm.

  • File docs/root/configuration/upstream/cluster_manager/cluster_runtime.rst

Screen Shot 2020-12-16 at 10 19 40 AM

  • File docs/root/install/building.rst

Screen Shot 2020-12-16 at 10 23 45 AM

  • File docs/root/configuration/security/secret.rst
Upstream clusters are handled in a similar way, if a cluster client certificate needs to be fetched by SDS remotely, it will NOT be marked as active and it will not be used before the certificates are fetched. If Envoy fails to fetch the certificates due to connection failures, or bad response data, the cluster will be marked as active, it can be used to handle the requests, but the requests routed to that cluster will be rejected.

If Envoy fails to fetch the certificates due to connection failures, or bad response data, the cluster will be marked as active
should be
If Envoy fails to fetch the certificates due to connection failures, or bad response data, the cluster will be marked as NOT active?

@WisWang
Copy link

WisWang commented Jan 12, 2021

File docs/root/configuration/http/http_filters/jwt_authn_filter.rst 58行:

The *provider_name* must be unique, it is referred in the `JwtRequirement <envoy_v3_api_msg_extensions.filters.http.jwt_authn.v3.JwtRequirement>` in its *provider_name* field.
should be
The *provider_name* must be unique, it is referred in the :ref:`JwtRequirement <envoy_v3_api_msg_extensions.filters.http.jwt_authn.v3.JwtRequirement>` in its *provider_name* field.

miss a :ref:

@Edward-Gavin
Copy link

Edward-Gavin commented Feb 5, 2021

File docs/root/configuration/http/http_conn_man/response_code_details.rst line 41 and line 42 is duplicated,

41: response_payload_too_large, Envoy is doing non-streaming proxying and the response payload exceeded configured limits.
42: response_payload_too_large, Envoy is doing non-streaming proxying and the response payload exceeded configured limits.

please delete one line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants