Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Support specifying batch limit #634

Closed
mluggy opened this issue Jul 25, 2019 · 2 comments · May be fixed by #644
Closed

Support specifying batch limit #634

mluggy opened this issue Jul 25, 2019 · 2 comments · May be fixed by #644
Labels
feature-request P0

Comments

@mluggy
Copy link

mluggy commented Jul 25, 2019

On high-velocity metrics, you get:
UnhandledPromiseRejectionWarning: Error: Field timeSeries had an invalid value: A maximum of 200 TimeSeries can be written in a single request.

Apparently Stackdriver backend has the limit that each request cannot batch more than 200 time series so exporter needs to do some processing. For example https://github.com/census-instrumentation/opencensus-java/blob/9b2ac2bdc9565517155a9efb1b8581d1a91329dc/exporters/stats/stackdriver/src/main/java/io/opencensus/exporter/stats/stackdriver/CreateTimeSeriesExporter.java#L76-L77.

Using 0.0.16.
@mayurkale22 mayurkale22 mentioned this issue Aug 26, 2019
Open
@mayurkale22
Copy link
Member

@mluggy Thanks for reporting this! I managed to repro the issue. I have opened the PR #644 to address this, Please take a look when you have a time.

@mayurkale22 mayurkale22 added the P0 label Aug 27, 2019
@mluggy
Copy link
Author

mluggy commented Sep 2, 2019

looks awesome.

@mluggy mluggy closed this as completed Sep 2, 2019
@TigerHe7 TigerHe7 mentioned this issue Jun 8, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request P0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: add batch limit for stackdriver exporter mayurkale22/opencensus-node
2 participants
@mluggy @mayurkale22