-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default crypto library is aws-lc
#8608
Comments
Ideal case: we use |
Do you mean switching to |
Yes |
I don't think it would be ideal, having fixed dependencies is a plus for me. Introducing extra complexity and brittleness to better handle uncommon builds (non linux/macos, non amd64/aarch64) is not a worth tradeoff in my view. |
The current default crypto library is
aes-gcm
since it has a broader compatibility without any additional dependencies, but it's also slower and different from release builds which are built usingaws-lc
.The default features in command should switch to
aws-lc
, and we should print a warning when compiling on a non-supported platform (linux/mac amd64/aarch64), advising the user of the possibility of using rust-crypto or adding the extra dependencies.Also, the CI will be using the default features rather than manually specifying them in multiple locations.
The text was updated successfully, but these errors were encountered: