Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type-safety for Identity arguments in ockam_command #7819

Open
SanjoDeundiak opened this issue Mar 28, 2024 · 6 comments
Open

Improve type-safety for Identity arguments in ockam_command #7819

SanjoDeundiak opened this issue Mar 28, 2024 · 6 comments

Comments

@SanjoDeundiak
Copy link
Member

SanjoDeundiak commented Mar 28, 2024

We have multiple places where we accept Identity change history as a hex encoded string like here or here (there may be more places like that). It would be great to have a value_parser that would validate and decode that argument to ChangeHistory type

@Nathy-bajo
Copy link
Contributor

Hey @SanjoDeundiak

I'd love to work on this and drop a PR.

@etorreborre
Copy link
Member

@Nathy-bajo that's awesome, all yours. Please let us know if your have any questions as you explore. You can also ask questions on the contributors discord https://discord.gg/RAbjRr3kds

@Nathy-bajo
Copy link
Contributor

Hey @etorreborre so sorry for the late response. I just dropped a PR for the fix.
Please can you help check on it?

@etorreborre
Copy link
Member

Sure, but I can't find you PR: https://github.com/build-trust/ockam/pulls/nathy-bajo

@Nathy-bajo
Copy link
Contributor

Sure, but I can't find you PR: https://github.com/build-trust/ockam/pulls/nathy-bajo

This is the link.

#8365

@Nathy-bajo
Copy link
Contributor

@etorreborre Please can you review it so I'll know if changes might still be needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants