Release: java_tools v13.14.0

[iancha1992]

Link to relevant issue and/or commit:
bazelbuild/rules_java#249

Other details:
java_tools 13.14.0
rules_java 8.7.0

cc @bazelbuild/triage

[iancha1992]

Step 2: https://buildkite.com/bazel-trusted/java-tools-binaries-java/builds/266

Step 3:
COMMIT_HASH: 1d4f849a7ebc6231cdcbcc403e4e9dad51fceb11

Step 4:

{
  "version": "v13.14",
  "release": "false",
  "artifacts": {
    "java_tools_linux": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.14/java_tools_linux-v13.14-rc1.zip",
      "sha": "81c7645005cea3e332edf478a7a3a4305bdc50921b0fb865a13e3d82f6ff8288"
    },
    "java_tools_windows": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.14/java_tools_windows-v13.14-rc1.zip",
      "sha": "672ff6b3bd42824cc60b9bf8321be24f20cccf9531022e6f9db445cae16ff30d"
    },
    "java_tools_darwin_x86_64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.14/java_tools_darwin_x86_64-v13.14-rc1.zip",
      "sha": "4e23bc21453aa35fcc3621fab0e4b056d33d7a86e72198f6b7b6d23073299cb1"
    },
    "java_tools_darwin_arm64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.14/java_tools_darwin_arm64-v13.14-rc1.zip",
      "sha": "709abb61f7a5e4855ab7f875b3ae6ccab168ff61115ced37cab1c8ec70e58408"
    },
    "java_tools": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.14/java_tools-v13.14-rc1.zip",
      "sha": "6cdab4ced656b1ec0ed3132436b711e9dc983d556f76397bbb79e3125a41b88c"
    }
  }
}

Step 5:
bazelbuild/rules_java@382cc54
382cc54efd103279e03e7c5b2a394694441d60ec

Step 6/7:
PR: bazelbuild/bazel#24696
Presubmit: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/25344

Step 8:
Downstream: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4386

Step 9:

{
  "version": "v13.14",
  "release": "true",
  "artifacts": {
    "java_tools_linux": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.14/java_tools_linux-v13.14.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.14/java_tools_linux-v13.14.zip",
      "sha": "81c7645005cea3e332edf478a7a3a4305bdc50921b0fb865a13e3d82f6ff8288"
    },
    "java_tools_windows": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.14/java_tools_windows-v13.14.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.14/java_tools_windows-v13.14.zip",
      "sha": "672ff6b3bd42824cc60b9bf8321be24f20cccf9531022e6f9db445cae16ff30d"
    },
    "java_tools_darwin_x86_64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.14/java_tools_darwin_x86_64-v13.14.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.14/java_tools_darwin_x86_64-v13.14.zip",
      "sha": "4e23bc21453aa35fcc3621fab0e4b056d33d7a86e72198f6b7b6d23073299cb1"
    },
    "java_tools_darwin_arm64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.14/java_tools_darwin_arm64-v13.14.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.14/java_tools_darwin_arm64-v13.14.zip",
      "sha": "709abb61f7a5e4855ab7f875b3ae6ccab168ff61115ced37cab1c8ec70e58408"
    },
    "java_tools": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.14/java_tools-v13.14.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.14/java_tools-v13.14.zip",
      "sha": "6cdab4ced656b1ec0ed3132436b711e9dc983d556f76397bbb79e3125a41b88c"
    }
  }
}

Step 10:
https://github.com/bazelbuild/java_tools/releases/tag/java_v13.14

Step 11:
rules_java PR: bazelbuild/rules_java#262

Step 12:
rules_java released: https://github.com/bazelbuild/rules_java/releases/tag/8.7.0
BCR PR: bazelbuild/bazel-central-registry#3578

[saraadams]

Correction: this will be 13.14. I initially looked at the first listed version shown on https://github.com/bazelbuild/java_tools/releases but just saw that the current version is 13.13

[iancha1992]

@hvadehra Is this failure okay in the downtream?
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4317#0193b7f3-3916-458f-be4c-4423f3407b71

I'd be glad to go forward with this once you confirm. Thanks

[hvadehra]

@iancha1992 The failures look unrelated to me, but given bazelbuild/bazel#24604 (comment) and bazelbuild/bazel#24604 (comment) , let's make a new RC from HEAD?

[saraadams]

Do you have an update on when this release might be completed? Are there further code changes needed, or is it mostly about sorting out the internal release process?

[iancha1992]

Do you have an update on when this release might be completed? Are there further code changes needed, or is it mostly about sorting out the internal release process?

@saraadams We are currently last couple steps away from being done with this. We'll complete this very soon. My apologies. Thanks for your patience.

[saraadams]

Just a quick heads up that I tried upgrading to rules_java version 8.7.1 - which includes this version of java_tools and ran into an error:

on macOS:

external/rules_java++toolchains+remote_java_tools/java_tools/src/main/cpp/util/file_posix.cc:137:7: error: no matching function for call to 'mkdtemp'
  if (mkdtemp(&path.data()[0]) == nullptr) {
      ^~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/unistd.h:673:7: note: candidate function not viable: 1st argument ('const value_type *' (aka 'const char *')) would lose const qualifier
char    *mkdtemp(char *);
         ^
1 error generated.

on Linux:

external/rules_java++toolchains+remote_java_tools/java_tools/src/main/cpp/util/file_posix.cc: In function 'blaze_util::Path blaze_util::CreateSiblingTempDir(const blaze_util::Path&)':
external/rules_java++toolchains+remote_java_tools/java_tools/src/main/cpp/util/file_posix.cc:137:15: error: invalid conversion from 'const char*' to 'char*' [-fpermissive]
  137 |   if (mkdtemp(&path.data()[0]) == nullptr) {
      |               ^~~~~~~~~~~~~~~
      |               |
      |               const char*
In file included from /usr/include/c++/10/cstdlib:75,
                 from /usr/include/c++/10/stdlib.h:36,
                 from external/rules_java++toolchains+remote_java_tools/java_tools/src/main/cpp/util/file_posix.cc:20:
/usr/include/stdlib.h:731:29: note:   initializing argument 1 of 'char* mkdtemp(char*)'
  731 | extern char *mkdtemp (char *__template) __THROW __nonnull ((1)) __wur;
      |                       ~~~~~~^~~~~~~~~~

This error looks to be caused by https://github.com/bazelbuild/bazel/blame/c3a3804678a0ebf6d05cf2ec9070178ccf766157/src/main/cpp/util/file_posix.cc#L137 - which was merged on 2024-11-21: bazelbuild/bazel@6906ba6#diff-83cfe165f1bd78a7736edc353ec60148796236c9076c75ed152d35e25a70077bL136-L137

[mbland]

Just filed bazelbuild/bazel#24957 as well, since the code resides there.

[mbland]

As noted in bazelbuild/bazel#24957 (comment), we've been able to move forward by setting --cxxopt="-std=c++17" on all our platforms and having everything pass CI with rules_java 8.7.1 and bazel_tools 13.14.