-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AwsV4HttpSigner does not contain all features from Aws4Signer #5401
Comments
The equivalent of presign in AwsV4HttpSigner is to set property AwsV4FamilyHttpSigner.AUTH_LOCATION to QUERY_STRING. Let us know if this is not what you're looking for. |
Hey @debora-ito , thanks for quick response! Please correct me if I am wrong, but this is how I got it. If I have service to service communication which can use AWS sigv4 I would have to unpack signed request to get signature right (lets say I am not using Apache HTTP client where you can just pass request)? First example and use case here. Would it make sense to have Second example I see in theory you could cache the signature for very short time spans and this lowering https calls you are making to AWS as well. (Although not sure how secure this really is). As third example I see more power and easier of use when integrating this in Spring WebClient, since they do serialisation/deserialisation for you meaning we are moving from HTTP request to Object -> Json, Header -> Map<> and this makes integration dirty to unwrap Edit: Forgot to add use case four when using gRPC communication I might want to have it in metadata part. |
I think we have stumbled upon the same issue after updating from before:
After:
So my guess is that HTTP request was signed, thus we had no @debora-ito , any chances this usecase could be taken into consideration? Thanks in advance. |
@debora-ito , sorry for bothering you again, just wanted to know whether my assumptions were correct or should I dig further? |
Describe the feature
Introduce presign option like in Aws4Signer since it is useful when you don't want to issue it with http request call.
AwsV4HttpSigner does not support this option.
Use Case
Aws4Signer had a feature to presign requests which was useful when you wanted to use SIGV4 and use for example Spring Boots WebClient to set it in header or body.
Check following docs here and search for presign method.
Proposed Solution
No response
Other Information
No response
Acknowledgements
AWS Java SDK version used
2.26.0
JDK version used
17 Corretto
Operating System and version
Mac OS
The text was updated successfully, but these errors were encountered: