-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all test failed plugins from the README #183
Comments
CC: @blimmer ( |
Of course, I can help you run the test correctly again. |
I do recognize that there are issues for newer versions of mongodb, but its fix is not trivial, and I cannot work on fixing it right away. As such, please remove |
@sylph01 OK. I'm looking forward to your contact. |
I currently don't have bandwidth to maintain |
@odarriba We already manage a lot of plugins, for example the Standard ML plugin has been transferred by the author. If you okay, I will send you an invitation to prepare for the transfer. |
@imbsky let's transfer it then! |
@odarriba Sent! |
hey @imbsky. |
@imbsky Just got asdf-rust fixed up, all green! Thanks for the reminder. |
@marciogm Sent! |
@nickveys Thank you! Really quick work! |
I fixed the asdf-crystal's CI and dealt with all issues. |
@imbsky it looks like there's some kind of issue with Travis CI's badge on that repo. The tests are actually passing, even though the badge says that they're not: I opened Ibotta/asdf-brig#8 to see if they can fix up the badge, as I no longer have maintainer abilities on that repo. |
Thank you for checking! Hmm, that's weird... We've created a great tool for GitHub Actions, so it might be a good idea to move to it. https://github.com/asdf-vm/actions |
Sounds good. I opened Ibotta/asdf-brig#9 for them to consider, since I don't have maintainer privs anymore. Thanks! |
@blimmer Thank you again for your quick response! |
@imbsky Sorry for being late, I've fixed |
@ndac-todoroki Great! |
As a whole I think asdf community is a great thing, I'd be happy to pass |
@mikestephens I sent you an invitation! |
@imbsky Fixed the asdf-scala plugin =) |
@mtatheonly Thank you! |
Nice, I'll also try fixing mines this weekend and transfer them. |
Awesome! By the way, most plugins have been fixed by the author or community maintainer. Thanks to everyone who helped us. |
|
@particledecay All right! |
I just setup GitHub Actions on asdf-php in asdf-community/asdf-php#31! |
I also added CI setup to elasticsearch. |
Sorry for the late response, |
@richin13 No worries! Thank you! |
|
Thanks! |
|
Thanks! |
I think, this can be automated.. |
I don't want to remove plugins automatically. GitHub checks have intermittent failures more frequently than I enjoy. I did update the CI so commits on the default branch tests all plugins and summarizes the information. For example:
I think there are ways to further automate this and report to the authors that there are issues, whether by tagging them in a thread in this repo or by opening Issues in the plugin repos. However, I don't feel the effort is worth the reward. Very few people seem to complain about plugins actually not working. It's only a few times a year that we replace unmaintained plugins with new forks. Although some of the repos here might not work, they give people a place to fork from and then we can update this repo with their new plugins. This is a health check at best. It isn't, and shouldn't, be a tool for people to gauge plugin health, robustness or trust. I try to point this out as much in this repo's README, SECURITY file and core tool documentation site. |
I agree, not removing plugins directly, instead automating the notification of failed builds, with a warning of grace time, say 3 to 6 months to fix the build. It's more of a maintenance status check, and yeah I also doubt if it's worth the effort. |
We are currently considering removing all test failed plugins from the README. Do you have the bandwidth to fix so that the test runs correctly again. Whether you have bandwidth or not, we recently started a collaborative, community-driven project called asdf-community for long-term maintenance of asdf plugins, so consider moving your plugins here.
https://github.com/asdf-community/.github
I'm tagging all the authors of the related plugin (in no particular order), but I'd like to hear everyone's opinions.
Ibotta/asdf-brig
)marciogm/asdf-crystal
)mikestephens/asdf-elasticsearch
)vic/asdf-graalvm
)vic/asdf-haskell
)rkyleg/asdf-julia
)sylph01/asdf-mongodb
)richin13/asdf-neovim
)particledecay/asdf-osctl
)odarriba/asdf-php
)code-lever/asdf-rust
)mtatheonly/asdf-scala
)RykHawthorn/asdf-tflint
)ndac-todoroki/asdf-v
)The text was updated successfully, but these errors were encountered: