You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched in the issues and found no similar issues.
What would you like to be improved?
Currently, we'll process memory value and unit manually(et resource configuration in optimizerGroup), and the unit only support m/g, if user configured with mb/gb, we'll get a wrong parsed value.
How should we improve?
Support a MemorySize to parse the memory size with the unit, support the following values: 1, 1k, 1kb, 1kibibytes, etc.
In addition to the issues mentioned in the issue above, there is another concern: the default unit for setting flink-conf.jobmanager.memory.process.size and flink-conf.taskmanager.memory.process.size in plain numeric strings is mb, which is inconsistent with the default unit of byte in the flink native parameter and may cause inconvenience for users familiar with flink when using this parameter.
In #3409, I add MemorySize to the amoro-common module for parsing flink's memory parameters, consistent with flink's native parsing logic.
Search before asking
What would you like to be improved?
Currently, we'll process memory value and unit manually(et resource configuration in optimizerGroup), and the unit only support
m
/g
, if user configured withmb
/gb
, we'll get a wrong parsed value.How should we improve?
Support a
MemorySize
to parse the memory size with the unit, support the following values:1
,1k
,1kb
,1kibibytes
, etc.this new one can be compatible with the old one.
Are you willing to submit PR?
Subtasks
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: