-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghostty album cover image #660
Comments
It is rendered for me using ghostty on x86 Linux with Wayland.. are you maybe using a multiplexer like tmux? That could interfere with spotify_player being able to detect the terminal |
Try running spotify_player (built with the image feature ofc) using |
Hi, thank you! Yes, tmux was the issue. Is there a way to get a proper rendering inside tmux? I didn't see anything in the docs. |
Hmm, not sure if this is an issue with this project, tmux or ghostty. Do you know if it works with tmux in kitty terminal? If so, that indicates that it should be solved in ghostty or tmux. However, some other apps like yazi work for me in tmux with ghostty so maybe this can be fixed in here directly. Unfortunately, I have no experience whatsoever with the kitty protocol and have no idea how to check if it is available. |
Seems to be handled by https://github.com/atanunq/viuer |
Maybe relevant: atanunq/viuer#67 |
They check for "ghostty" in the "$TERM" environment variable. Maybe set it manually for now? |
Okay, when I do |
Same for doing it through tmux and updating "TERM_PROGRAM" |
I wonder how yazi (and image.nvim) do it...? I have
in my tmux config but not quite sure what it does tbh |
Just commented out these lines and yazi kitty still works lol |
Seems like this needs to be addressed in viuer because when we set the terminal to "xterm-ghostty" within tmux, |
Is your feature already implemented in the latest
master
?No
Is your feature request related to a problem? Please describe.
Ghostty terminal supports kitty graphics but the album cover is not rendered using it.
Describe the solution you'd like
Use kitty graphics protocol to display album cover.
The text was updated successfully, but these errors were encountered: