Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focusing On Other Application While Saving Pipeline Crashes Grip on MacOS (Does Not Save Pipeline) #989

Open
Braykoff opened this issue Aug 17, 2022 · 6 comments

Comments

@Braykoff
Copy link

When in GRIP on macOS, when you are saving the pipeline and choosing the save location, clicking out of the application (into any other application, or the desktop) causes GRIP to crash with no error, destroying any unsaved work.

Video

Steps to Reproduce:

  • Open Grip
  • Press File > Save
  • Click into any other application (remove focus from GRIP)
  • When the 'Choose Save Location' Finder window opens on GRIP, click into it
  • Click into any other application again (remove focus from GRIP)
  • GRIP crashes

I can not confirm if this happens on Windows too.

@JLLeitschuh
Copy link
Member

Do you have an exception from the log file you can share with us?

@Braykoff
Copy link
Author

@JLLeitschuh The log file doesn't have an exception:

Aug 18, 2022 1:00:41 PM edu.wpi.grip.core.util.service.LoggingListener starting
INFO: [PipelineRunner] Starting
Aug 18, 2022 1:00:47 PM edu.wpi.grip.core.events.EventLogger eventPosted
INFO: Event on thread 'JavaFX Application Thread': StepAddedEvent{step=Step{operation=Desaturate}, index=OptionalInt[0]}
Aug 18, 2022 1:00:47 PM edu.wpi.grip.core.events.EventLogger eventPosted
INFO: Event on thread 'JavaFX Application Thread': StepAddedEvent{step=Step{operation=Distance Transform}, index=OptionalInt[1]}

(I added random steps just to see if they would appear in the log)
When it crashes, nothing is added.
GRIP.log.lck is blank.

@JLLeitschuh
Copy link
Member

I have a sneaking suspicion this is out of our control to fix. It sounds like an OS bug

@Braykoff
Copy link
Author

@JLLeitschuh

I can confirm that this does not occur in other macOS applications. I have tried the steps in Text Edit (the built-in text editor) and IDLE (Python IDE, neither built-in nor made by Apple). Neither application crashed when the 'save as' window was unfocused. This might be an OS bug, however, it only seems to affect GRIP.

@SamCarlberg
Copy link
Member

@Braykoff:

  1. What version of GRIP are you experiencing this with?
  2. What version of maOS?
  3. What Apple hardware (eg Macbook Pro 2019)?

@SamCarlberg
Copy link
Member

FWIW, I can't repro this with a 2020 M1 Macbook Air

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants