Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from strings to keywords as "type of step" labels #88

Open
NicMcPhee opened this issue Jun 3, 2019 · 0 comments
Open

Switch from strings to keywords as "type of step" labels #88

NicMcPhee opened this issue Jun 3, 2019 · 0 comments

Comments

@NicMcPhee
Copy link
Member

In functions like recursive-validate we're passing in a sequence of strings that indicate whether a given step is an equivalence/equality step or an implication step.

We probably ought to be using keywords like :equals and :implies (and :follows-from when we implement that in #75) instead of just strings.

I also wonder if passing in these parallel sequences is the best bet here. We could instead have a single, structured input instead. That might simplify some things where, for example, we currently have to worry about the number of rules and expressions not lining up correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant