Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra options for specifying the API key #18

Open
davep opened this issue Sep 7, 2023 · 0 comments
Open

Extra options for specifying the API key #18

davep opened this issue Sep 7, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@davep
Copy link
Contributor

davep commented Sep 7, 2023

At the moment, if you want to serve your applications via an account, the API key needs to go into [account] section of your configuration file. Depending on the type of application, how it's being served, and who the audience is, this could be an issue. If, for example, some application that's being served allows a way of viewing the content of a file in the current directory1, this would mean that anyone with the URL could get the API key for that account.

I think there's a couple of things we may want to do here:

  1. Include in any documentation a clear description of how this is something to keep in mind, and that users should think carefully about what applications they serve and who they give access to.
  2. Consider adding other routes via which the API key can be provided to textual-web (for example, perhaps from an environment variable, or a keychain, or ~/.authinfo, or...).

Footnotes

  1. There are of course more general issues about applications that provide filesystem access; we may want to think about a very general "best practices" document when it comes to applications and security at some point.

@davep davep added the enhancement New feature or request label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant