You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently add_on_binder_for_namespace places the call to the function containing the custom manual bindings before binder-generated code. This means that the custom code cannot do several things, including:
Bind a class that's a subclass of an automatically bound class, since that class is not yet known
Set pybind11 default args to automatically bound types, since they haven't been registered yet
Thus, if there is no special reason to place the custom code before the generated one, it seems useful to do the opposite, so that the custom code can take advantage of what's already present in the generated one.
The text was updated successfully, but these errors were encountered:
@simleo i see your point. If i remember correctly there was a technical reason that made placing namespace binding on top, - i will see if it possible refactor this.
Currently
add_on_binder_for_namespace
places the call to the function containing the custom manual bindings before binder-generated code. This means that the custom code cannot do several things, including:Thus, if there is no special reason to place the custom code before the generated one, it seems useful to do the opposite, so that the custom code can take advantage of what's already present in the generated one.
The text was updated successfully, but these errors were encountered: