Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLServer does not return exception when sent incorrect protocol #29

Open
dclements opened this issue Jan 7, 2013 · 0 comments
Open
Labels

Comments

@dclements
Copy link
Contributor

As a developer, I would like to receive a usable error when I send something that does not fit with the current protocol specification so that I can have an easier time debugging clients and taking into account protocol changes.

Currently when sent something that cannot be decoded into the protocol (type:boolean,len:int,msg) then I do not receive anything back as a response, with the following error on the server:

com.readytalk.revori.server.SQLServer$Client run
WARNING: null
java.lang.ArrayIndexOutOfBoundsException: <type-value>
    at com.readytalk.revori.server.SQLServer.handleRequest(SQLServer.java:2684)
    at com.readytalk.revori.server.SQLServer.access$3(SQLServer.java:2671)
    at com.readytalk.revori.server.SQLServer$Client.run(SQLServer.java:487)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    at java.lang.Thread.run(Thread.java:680)

When the protocol object cannot be fully decoded, I would like to receive an exception telling me that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant