Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research intermediary file hosting service #242

Closed
4 tasks
jwflory opened this issue Feb 15, 2020 · 1 comment
Closed
4 tasks

Research intermediary file hosting service #242

jwflory opened this issue Feb 15, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists new change Adds new capabilities or functionality research Research and more data is needed to make a decision Telegram Issues relating to Telegram bridge

Comments

@jwflory
Copy link
Member

jwflory commented Feb 15, 2020

Summary

When a Telegram user sends a document file, upload it to an intermediary file hosting service to avoid leaking API key

Background

Is your feature request related to a problem? Please describe:

In v1.x.x, there is an option (disabled by default) to support sending documents from Telegram to IRC. As noted in #241, this leaks the Telegram bot API key. For the v2.x.x rewrite, we should not include this as an option without a way to mask the API key.

Describe the solution you'd like:

We might be able to use a third-party service, such as Dropbox, Mega, or other platforms to host documents. We could provide an API key option for a user to configure for any of these services.

Describe alternatives you've considered:

First we need to figure out what our possible platforms/services are.

Details

https://core.telegram.org/api/files

  • Evaluate existing file hosting services out there
  • Evaluate which ones have good Go libraries available
  • Research rate-limiting for each platform
  • Make final decision for what we will support and whether a default option is provided

Outcome

Successfully share files from Telegram to IRC without exposing Telegram bot API key

@jwflory jwflory added new change Adds new capabilities or functionality research Research and more data is needed to make a decision Telegram Issues relating to Telegram bridge labels Feb 15, 2020
@jwflory jwflory added this to the v2.x.x milestone Feb 15, 2020
@jwflory jwflory removed this from the v2.x.x milestone Feb 16, 2020
@jwflory jwflory added the duplicate This issue or pull request already exists label Feb 16, 2020
@jwflory
Copy link
Member Author

jwflory commented Feb 16, 2020

Well, would you look at that? We already have an issue open for this: #159. 😅 Closing this one as a duplicate, let's use the older issue for discussing and tracking this.

@jwflory jwflory closed this as completed Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists new change Adds new capabilities or functionality research Research and more data is needed to make a decision Telegram Issues relating to Telegram bridge
Projects
None yet
Development

No branches or pull requests

1 participant