Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with GOG Galaxy #948

Open
LinguaOccultus opened this issue Jun 1, 2024 · 25 comments
Open

Issues with GOG Galaxy #948

LinguaOccultus opened this issue Jun 1, 2024 · 25 comments
Labels
winapp2 For issues related to winapp2.ini

Comments

@LinguaOccultus
Copy link

Hello,

I am using CCEnhancer (https://singularlabs.com/software/ccenhancer/) and was told, this is the winapp2.ini file, it downloads.

Currently, there is an issue with the cleaning rule for Games/Galaxy. When using it, it removes also customizations for the list views of the GOG Galaxy client which is surely unintended. For example, hidden columns re-appear and sorting is reset also. It seems like the GOG Galaxy client writes those settings to a file which gets deleted with this rule. Unfortunately, I have not found out by now, which one. Aside that, it is completely reproducable and since I excluded this rule, everything is fine again.

Best regards,

Tim

@TZocker
Copy link
Contributor

TZocker commented Jun 2, 2024

Hi Tim,

I can repruduce your ussue.
But I think it's the same with browser celaning ....

The rule deletes lokal settings for sorting the gamelist to default.

PS: Hidden games are hidden after cleaning.

I would suggest to creat a warning.

Best regards.

TZocker added a commit to TZocker/Winapp2 that referenced this issue Jun 2, 2024
@LinguaOccultus
Copy link
Author

Hi,

I know that this game is always a trade-off between the stuff you want (like logs, caches, etc.) to delete and stuff you want to keep (like application settings, for example). Sometimes it is possible to separate them and create two rules instead which is why I wanted your attention on it.

Anyway, when not possible: yes, a warning should be placed since most users surely will want to keep their settings.

Hidden games seems to be my error and I am quite sure this is a global setting on the servers so they are not visible in the web library, too.

I come every now and them to a point like this and will report them in here directly now, so the CCEnhancer guy (Shawn or Shane?) does not have to forward them anymore! ;-)

Thanks and greetings,

Tim

@TZocker
Copy link
Contributor

TZocker commented Jun 2, 2024

Hi,
So i think its one file in:

C:\ProgramData\GOG.com\Galaxy\webcache\common\Local Storage\leveldb

ExcludeKey1=PATH|%CommonAppData%\GOG.com\Galaxy\webcache\common\Local Storage\leveldb|*.*

On my pc 000003.log ....

We have to make more research.

Can you test it, pls?

@APMichael APMichael added the winapp2 For issues related to winapp2.ini label Jun 3, 2024
@APMichael
Copy link
Collaborator

The environment variable %CommonAppData% was apparently replaced by the variable %ProgramData% after the big overhaul. And with an ExcludeKey, the path should always end with \|.

The ExcludeKey should therefore look like this:
ExcludeKey1=PATH|%ProgramData%\GOG.com\Galaxy\webcache\common\Local Storage\leveldb\|*

@LinguaOccultus
Copy link
Author

Hello,

thanks for the feedback. Unfortunately, I am on the road for a few days from work, so I cannot test this immediately ...

TZocker added a commit to TZocker/Winapp2 that referenced this issue Jun 3, 2024
@TZocker
Copy link
Contributor

TZocker commented Jun 3, 2024

The environment variable %CommonAppData% was apparently replaced by the variable %ProgramData% after the big overhaul. And with an ExcludeKey, the path should always end with \|.

The ExcludeKey should therefore look like this: ExcludeKey1=PATH|%ProgramData%\GOG.com\Galaxy\webcache\common\Local Storage\leveldb\|*

Thx, for the information but it's not noticed in the readme ...

@APMichael
Copy link
Collaborator

I just noticed today that all %CommonAppData% have been replaced by %ProgramData%. 😄

@TZocker
Copy link
Contributor

TZocker commented Jun 3, 2024

Next big search and replacement ? :D

@APMichael
Copy link
Collaborator

... Unfortunately, I am on the road for a few days from work, so I cannot test this immediately ...

Have you had time to test the ExcludeKey? Does it work as intended?

#948 (comment)

@LinguaOccultus
Copy link
Author

LinguaOccultus commented Jun 25, 2024

Sorry, misunderstood you here. Thought, I was meant to wait until this is released. I always check with CCEnhancer before each CCleaner use and since the warning also is still missing ...

Anyway, with the latest GOG Galaxy version this seems to work in a quick first test. Seems they really made some changes again, but the 2.0 version I am using is in beta for how many YEARS now? :-D So I guess, we will see changes here again.

@APMichael
Copy link
Collaborator

Thank you for your reply. Then @TZocker can update his pull request #949 accordingly.

@LinguaOccultus
Copy link
Author

No worries; I will test again as soon as there is the warning implemented as I know then the rule is updated.

@TZocker
Copy link
Contributor

TZocker commented Jun 25, 2024

@jensdraht1999
Copy link

Guys, what about older ccleaner versions. Don't want to update ccleaner, want to stay on 5.42 version, so at least give as an option to stay on older version. The newer versions of ccleaner are unbearable.

@LinguaOccultus
Copy link
Author

Guys, what about older ccleaner versions. Don't want to update ccleaner, want to stay on 5.42 version, so at least give as an option to stay on older version. The newer versions of ccleaner are unbearable.

Even though it is off topic ... ;-) You can use winapp2.ini with each version (and several programs; see desciption on the start page).

And if you find stuff like notifications and such on newer versions annoying, just block CCleaner in your firewall. However, this also prevents it from autoupdate and some functions like driver and software updates ...

@APMichael
Copy link
Collaborator

Guys, what about older ccleaner versions. Don't want to update ccleaner, want to stay on 5.42 version, so at least give as an option to stay on older version. The newer versions of ccleaner are unbearable.

Replacing the environment variable (%CommonAppData% > %ProgramData%) is not a problem for older CCleaner versions. The variable was introduced with Windows Vista.

@jensdraht1999
Copy link

ner in your firewall. However, this also prevents it from autoupdate and some functions like driver and software updates ...

I can of course do that, but what about the bigger window size since version 6, where nearly all window space is taken. Ccleaner has become trash in the last time to be honest. Nothing substantially done, no infile cleaning for years. I gave up hope and want to stay on the last stable adfree/blockfree version with not bs. I wish, that I even could use an older version, if possible, but it seems not.

@jensdraht1999
Copy link

Guys, what about older ccleaner versions. Don't want to update ccleaner, want to stay on 5.42 version, so at least give as an option to stay on older version. The newer versions of ccleaner are unbearable.

Replacing the environment variable (%CommonAppData% > %ProgramData%) is not a problem for older CCleaner versions. The variable was introduced with Windows Vista.

This is good news then.

@LinguaOccultus
Copy link
Author

ner in your firewall. However, this also prevents it from autoupdate and some functions like driver and software updates ...

I can of course do that, but what about the bigger window size since version 6, where nearly all window space is taken. Ccleaner has become trash in the last time to be honest. Nothing substantially done, no infile cleaning for years. I gave up hope and want to stay on the last stable adfree/blockfree version with not bs. I wish, that I even could use an older version, if possible, but it seems not.

That's due to the Avast takeover of Piriform Ltd. back in 2017 – but it could have been much worse if you know Avast! ;-) On the other hand, no alternative ever convinced me and when you know what you do (and ignore the rest) ...

@jensdraht1999
Copy link

@LinguaOccultus That's way I think, we should develop our own cleaner for winapp2.ini (with still support for other cleaners).

I think with the help of ChatGTP or whatnot we have really good chances easily developing such a tool.

@LinguaOccultus
Copy link
Author

This entry still is missing the warning about resetting the GOG Galaxy (2.0) view settings and filters until today ...

About the off-topic about tools: Yes, the only way to have a really great tool is a new one. However, CCleaner still is much to useful and offers many different additional tools meanwhile I would not want to miss. To replace it with an open source and free community toll, there is MUCH effort needed. On the other hand, this has been done in other cases before ... (but I am not a developer).

@TZocker
Copy link
Contributor

TZocker commented Dec 22, 2024

We are waiting for @MoscaDotTo to merge.

@LinguaOccultus
Copy link
Author

No worries! ;-) Just used CCleaner yesterday and checked so I remember the discussion here and thought it might be helpful to give feedback until the issue is completely solved. I'll keep an eye on it ... thanks for the response!

@TZocker
Copy link
Contributor

TZocker commented Dec 22, 2024

@APMichael can you also merge?

Did you know something about MoscaDotTo, has she Illness?

@APMichael
Copy link
Collaborator

@APMichael can you also merge?
Did you know something about MoscaDotTo, has she Illness?

That should probably still be possible. However, I didn't really want to intervene until @MoscaDotTo had completed her major overhaul. I have no idea what progress has been made with her local copies.

Unfortunately, I don't know anything about her either. I hope she is doing well and will soon find more time for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
winapp2 For issues related to winapp2.ini
Projects
None yet
Development

No branches or pull requests

4 participants