-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the returns
library dependency
#3
Labels
chore
Non-functional work, such as refactoring or reformatting
Comments
chuckwondo
added
the
chore
Non-functional work, such as refactoring or reformatting
label
Jul 21, 2023
chuckwondo
added a commit
that referenced
this issue
Mar 18, 2024
In addition: - Fixed S3 credentials caching bug mentioned in a comment on #14 - Removed use of `returns` library from the granule download function and its related functions, as an incremental step towards addressing #3 - Replaced ShellCheck pre-commit check that uses a Docker container with direct use of shellcheck (added to dev dependencies) so that pre-commit can be run within the ADE (since the ADE does not have Docker installed)
chuckwondo
added a commit
that referenced
this issue
Mar 19, 2024
In addition: - Fix S3 credentials caching bug mentioned in a comment on #14 - Remove use of `returns` library from the granule download function and its related functions, as an incremental step towards addressing #3 - Replace ShellCheck pre-commit check that uses a Docker container with direct use of shellcheck (added to dev dependencies) so that pre-commit can be run within the ADE (since the ADE does not have Docker installed) - Fix "conda: command not found" error Replace `conda` with `"${CONDA_EXE:-conda}"` in all scripts to prevent scripts from failing due to not finding the `conda` command, which can happen when a script attempts to invoke conda from a subshell, and the subshell doesn't initialize conda. - Use `--live-stream` instead of `--no-capture-output` with `conda run`. These are synonyms, so this is simply a preference change. - Update pre-commit hooks and related dependencies - Reformat py files using `black`, which was previously accidentally excluded from pre-commit. - Update tests to match changes in maap-py types - Add conda lock file generation to pre-commit - Drop .sh suffix from shell scripts for convenience - Simplify build, run, and dev setup and update `CONTRIBUTING.md` accordingly. Fixes #44
chuckwondo
added a commit
that referenced
this issue
Mar 19, 2024
In addition: - Fix S3 credentials caching bug mentioned in a comment on #14 - Remove use of `returns` library from the granule download function and its related functions, as an incremental step towards addressing #3 - Replace ShellCheck pre-commit check that uses a Docker container with direct use of shellcheck (added to dev dependencies) so that pre-commit can be run within the ADE (since the ADE does not have Docker installed) - Fix "conda: command not found" error Replace `conda` with `"${CONDA_EXE:-conda}"` in all scripts to prevent scripts from failing due to not finding the `conda` command, which can happen when a script attempts to invoke conda from a subshell, and the subshell doesn't initialize conda. - Use `--live-stream` instead of `--no-capture-output` with `conda run`. These are synonyms, so this is simply a preference change. - Update pre-commit hooks and related dependencies - Reformat py files using `black`, which was previously accidentally excluded from pre-commit. - Update tests to match changes in maap-py types - Add conda lock file generation to pre-commit - Drop .sh suffix from shell scripts for convenience - Simplify build, run, and dev setup and update `CONTRIBUTING.md` accordingly. Fixes #44
chuckwondo
added a commit
that referenced
this issue
Mar 19, 2024
In addition: - Fix S3 credentials caching bug mentioned in a comment on #14 - Remove use of `returns` library from the granule download function and its related functions, as an incremental step towards addressing #3 - Replace ShellCheck pre-commit check that uses a Docker container with direct use of shellcheck (added to dev dependencies) so that pre-commit can be run within the ADE (since the ADE does not have Docker installed) - Fix "conda: command not found" error Replace `conda` with `"${CONDA_EXE:-conda}"` in all scripts to prevent scripts from failing due to not finding the `conda` command, which can happen when a script attempts to invoke conda from a subshell, and the subshell doesn't initialize conda. - Use `--live-stream` instead of `--no-capture-output` with `conda run`. These are synonyms, so this is simply a preference change. - Update pre-commit hooks and related dependencies - Reformat py files using `black`, which was previously accidentally excluded from pre-commit. - Update tests to match changes in maap-py types - Add conda lock file generation to pre-commit - Drop .sh suffix from shell scripts for convenience - Simplify build, run, and dev setup and update `CONTRIBUTING.md` accordingly. Fixes #44
chuckwondo
added a commit
that referenced
this issue
Mar 25, 2024
In addition: - Fix S3 credentials caching bug mentioned in a comment on #14 - Remove use of `returns` library from the granule download function and its related functions, as an incremental step towards addressing #3 - Replace ShellCheck pre-commit check that uses a Docker container with direct use of shellcheck (added to dev dependencies) so that pre-commit can be run within the ADE (since the ADE does not have Docker installed) - Fix "conda: command not found" error Replace `conda` with `"${CONDA_EXE:-conda}"` in all scripts to prevent scripts from failing due to not finding the `conda` command, which can happen when a script attempts to invoke conda from a subshell, and the subshell doesn't initialize conda. - Use `--live-stream` instead of `--no-capture-output` with `conda run`. These are synonyms, so this is simply a preference change. - Update pre-commit hooks and related dependencies - Reformat py files using `black`, which was previously accidentally excluded from pre-commit. - Update tests to match changes in maap-py types - Add conda lock file generation to pre-commit - Drop .sh suffix from shell scripts for convenience - Simplify build, run, and dev setup and update `CONTRIBUTING.md` accordingly. Fixes #44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I originally introduced the
returns
library in order to experiment with writing more Functional Programming oriented Python.While it was a worthwhile experiment, I'm in favor of removing it for at least the following reasons:
At another point, I would like to consider what appear to be a cleaner, simpler, more approachable, and more robust FP libraries (
pfun
orpymonad
), as I believe exploring FP concepts again/further is still worthwhile, particularly in the context of a smaller codebase, such as this one. However, for now, I want to simply remove the use ofreturns
so that we can address the points above.The text was updated successfully, but these errors were encountered: