New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing link to page on release verification after redesign #154

Open

aperezdc opened this issue Feb 24, 2023 · 0 comments

Labels

bug

Member

aperezdc commented Feb 24, 2023

After #123 there is no longer a visible link to https://wpewebkit.org/release/verify/

(Reported by @Bastian-Krause, thanks!)

aperezdc added the bug label

aperezdc mentioned this issue

Fix link to Carlos García Campos' key #146

Merged

aperezdc added a commit that referenced this issue


          CI: Give actions write permission to page contents

63cf8bf

According to https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-first-deployment-with-github_token
the solution is to ensure that the automatically-created token for the
Actions runners has write permission to update GitHub Pages contents.

Fixes #154

aperezdc mentioned this issue

CI: Give actions write permission to page contents #156

Merged

aperezdc added a commit that referenced this issue


          CI: Give actions write permission to page contents

c826e31

According to https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
using pull_request_target will use the base branch instead of the fork
branch. The base branch is considered trusted, and the automatic token
handed over to GHA will include write permission.

Fixes #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment