Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain uses of Islands cause your website to disappear #70

Open
happycollision opened this issue Jul 3, 2024 · 2 comments
Open

Certain uses of Islands cause your website to disappear #70

happycollision opened this issue Jul 3, 2024 · 2 comments

Comments

@happycollision
Copy link

happycollision commented Jul 3, 2024

As first mentioned in the Slack channel, depending on how you import/export an Island-ized component, your build will complete successfully but will result in an absurdly broken website.

components/basic/

  C.tsx

  D.tsx // imports C directly

components/modules/

  A.tsx // imports D as an island

  B.tsx // imports C directly

Result:

Screenshot 2024-06-26 at 3 19 13 PM (1)

@lt-frank-columbo
Copy link

Same issue here. We started using cms-react a month ago for a new project.

  1. We created a module (a module without any island)
  2. Deployed it on a dev-portal; all good.
  3. Days later, we deploy a new build (no issues in the log).
  4. All modules on the existing page show the same comment in the DOM as yours does. In the editor-sidebar, the fields are gone and say "The module used to create this content could not be found. [...]". When drag-n-dropping the same module into the page, the newly added module works just fine. It's just that all existing modules are broken.
    Re-deploying an old version of the build doesn't bring back the content.

@happycollision
Copy link
Author

I got word from the HS team working on react-cms that Slack is the better place for now to report (or +1) on bugs. See the readme in this repo for how to get invited in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants