Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve repo's pylint score #867

Open
Ishankoradia opened this issue Sep 28, 2024 · 5 comments
Open

improve repo's pylint score #867

Ishankoradia opened this issue Sep 28, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@Ishankoradia
Copy link
Contributor

Currently we have a pylint score of 6.5. Would be great to get it to 8.5.

To do this one will need update the pyproject.toml and set fail-under = 8.5 under the pylint section. Then run pre-commit run --all-files and fix the lint errors seen on console.

@Ishankoradia Ishankoradia added the good first issue Good for newcomers label Sep 28, 2024
@ghost
Copy link

ghost commented Oct 18, 2024

Hi @Ishankoradia , Can I try out this ?
Also can you please provide me discord link as I have few doubts related to local setup, I am getting invalid for the link provided

@Ishankoradia Ishankoradia assigned ghost Oct 19, 2024
@Ishankoradia
Copy link
Contributor Author

Ishankoradia commented Oct 19, 2024

Yes go for it.

@Alokih you can put your queries here also.
Did you try following the steps in readme ?

@ghost
Copy link

ghost commented Oct 19, 2024

Ok @Ishankoradia sir
I am trying to setup using docker. Actually I have doubt in .env file, I mean do I need to just populate airbyte & prefect proxy link & run docker ?
@fatchat sir ?

@Ishankoradia
Copy link
Contributor Author

Ishankoradia commented Nov 3, 2024

@Alokih if you want to run the entire setup you will need prefect proxy and airbyte.
But if you just want to run backend you can keep them empty and if you want to keep things simpler you could also create a virtual env & run djang from it.

Let me know your discord user id , i will add you to our server. Sorry for the late response.

@ghost ghost removed their assignment Nov 11, 2024
@adoo100
Copy link

adoo100 commented Nov 16, 2024

Hi @Ishankoradia I would love to tackle this issue and am confident that I can get it done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants