Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Supervisor.start_child call #152

Open
varnerac opened this issue Apr 18, 2020 · 2 comments
Open

Bad Supervisor.start_child call #152

varnerac opened this issue Apr 18, 2020 · 2 comments

Comments

@varnerac
Copy link
Contributor

In Ace.HTTP2.Connection there is a call to Supervisor.start_child/2 that doesn't have a child spec as the second argument.

https://github.com/CrowdHailer/Ace/blob/master/lib/ace/http2/connection.ex#L751

I am not sure what it's trying to do or how it could work.

@varnerac
Copy link
Contributor Author

@varnerac
Copy link
Contributor Author

varnerac commented Apr 18, 2020

Ok, I understand what happened here. Older versions of Elixir allowed the last argument to be a list of terms. That's no longer the case. This breaks dialyzer on recent version of Elixir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant