Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into the Outline button style defined in code by Neve FSE #84

Open
mghenciu opened this issue Sep 11, 2023 · 7 comments
Open

Look into the Outline button style defined in code by Neve FSE #84

mghenciu opened this issue Sep 11, 2023 · 7 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.

Comments

@mghenciu
Copy link
Contributor

Description

As reported here >> https://wordpress.org/support/topic/cant-modify-css-for-outlined-button/
The current approach is based on this issue: WordPress/gutenberg#34853

but thins changed in the meantime.

Step-by-step reproduction instructions

  1. Create a button element and set its style to be “Outline”
  2. Define specific values for this button’s CSS properties “padding” and “border” (this can be done in several ways, but the bellow efect will always be the same

What should happen

The outlined button CSS should accept and apply the user’s values
What happens instead

The outlined button CSS properties “padding” and “border” can’t be changed from some default values.

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot 2023-09-11 at 08 59 15

Environment info

No response

Is the issue you are reporting a regression

No

@mghenciu mghenciu added the bug This label could be used to identify issues that are caused by a defect in the product. label Sep 11, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Sep 11, 2023
@JohnPixle JohnPixle added this to the 1.1.0 milestone Sep 20, 2023
@HardeepAsrani
Copy link
Member

@JohnPixle I had discussed this with Mihai few days back and it works properly in the new version. Even when I had tried adding custom CSS, it was working nicely. Could've been an issue with a previous version of WP.

@JohnPixle
Copy link
Contributor

@HardeepAsrani Thanks! In this case feel free to close this issue, I don't have any other input.
Good to clear things up! 👍🏻

@JohnPixle JohnPixle removed this from the 1.0.6 milestone Oct 10, 2023
@HardeepAsrani
Copy link
Member

Just looping in @mghenciu to confirm it's the same issue, and not a separate one.

@mghenciu
Copy link
Contributor Author

Just looping in @mghenciu to confirm it's the same issue, and not a separate one.

Yeas, it's about the issue we talked about.
I still didn't managed to change the Style for the Outlined button - using Custom CSS.


But the question still remains: right now we use the Outline Style override, because before it wasn't possible to do it from the theme.json
Now this changed, and it's possible to configure the Outline style in the theme.json.

Up to you if it's worth updating it, if not - we can close this issue.

@JohnPixle
Copy link
Contributor

Thanks Mihai, makes sense. I'd say it would be good to address this if possible.

Let us know Hardeep!

@JohnPixle
Copy link
Contributor

For the record, I have tried this in Raft and it seems to work 🚀 . You can properly define styles for block variations
via theme.json

Codeinwp/raft#88

@matlembo
Copy link

Without specifying styles for the block variation I would expect the outlined button to inherit the spacing defined in styles->elements->buttons->spacing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.
Projects
None yet
Development

No branches or pull requests

5 participants