-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look into the Outline button style defined in code by Neve FSE #84
Comments
@JohnPixle I had discussed this with Mihai few days back and it works properly in the new version. Even when I had tried adding custom CSS, it was working nicely. Could've been an issue with a previous version of WP. |
@HardeepAsrani Thanks! In this case feel free to close this issue, I don't have any other input. |
Just looping in @mghenciu to confirm it's the same issue, and not a separate one. |
Yeas, it's about the issue we talked about. But the question still remains: right now we use the Outline Style override, because before it wasn't possible to do it from the theme.json |
Thanks Mihai, makes sense. I'd say it would be good to address this if possible. Let us know Hardeep! |
For the record, I have tried this in Raft and it seems to work 🚀 . You can properly define styles for block variations |
Without specifying styles for the block variation I would expect the outlined button to inherit the spacing defined in styles->elements->buttons->spacing. |
Description
As reported here >> https://wordpress.org/support/topic/cant-modify-css-for-outlined-button/
The current approach is based on this issue: WordPress/gutenberg#34853
but thins changed in the meantime.
Step-by-step reproduction instructions
What should happen
The outlined button CSS should accept and apply the user’s values
What happens instead
The outlined button CSS properties “padding” and “border” can’t be changed from some default values.
Screenshots, screen recording, code snippet or Help Scout ticket
Environment info
No response
Is the issue you are reporting a regression
No
The text was updated successfully, but these errors were encountered: