Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance when loading all POIs #212

Open
andersand opened this issue Aug 14, 2020 · 2 comments
Open

Improve performance when loading all POIs #212

andersand opened this issue Aug 14, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@andersand
Copy link

Also loading of POIs for 8192 map takes like 15 seconds.

I see (from performance logging tool in chrome devtools) that this seems to be caused by creating ~150000 nodes, then about 1000 event listeners.

It may be so that you could add only event listener to a containing div for mousemove to improve performance?

@niekcandaele
Copy link
Member

niekcandaele commented Aug 14, 2020

Weird, loading all POIs takes less than a second for me. It seems like you already have an idea on how to solve this, PRs welcome :)

This is probably the function you want to look into
https://github.com/CatalysmsServerManager/CPM-claim-creator/blob/master/src/components/SdtdMap.vue#L564

@niekcandaele niekcandaele added the enhancement New feature or request label Aug 14, 2020
@niekcandaele niekcandaele changed the title Panning the CPM map with POIs layer on takes a long time Improve performance when loading all POIs Aug 14, 2020
@andersand
Copy link
Author

That's interesting,I wonder if it could be my computer is older than yours or something. I only have 8GB RAM and i5 quad core CPU

Thanks for the code pointer, I'll try to look into it.

@andersand andersand reopened this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants