Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return List copy for getchangedcardtypes and cache getTypeWithChanges result #6579

Open
Hanmac opened this issue Nov 15, 2024 · 0 comments · May be fixed by #6580
Open

return List copy for getchangedcardtypes and cache getTypeWithChanges result #6579

Hanmac opened this issue Nov 15, 2024 · 0 comments · May be fixed by #6580
Assignees
@Hanmac @tool4ever
Labels
Game Mechanics

Comments

@Hanmac
Copy link
Contributor

Hanmac commented Nov 15, 2024

@tool4ever for a smaller HOTFIX before this MR, what about using getchangedcardtypes a ImmutableList.copy?
And maybe we could cache the result of getTypeWithChanges ? and or maybe cache the List?
Because it is also used for hasRemoveIntrinsic

Originally posted by @Hanmac in #6577 (comment)
@Hanmac Hanmac linked a pull request Nov 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hanmac Hanmac

@tool4ever tool4ever

Labels
Game Mechanics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Card: copy getChangedCardTypes Card-Forge/forge
2 participants
@Hanmac @tool4ever