Format with abbreviations not work

[minikinl]

Problem

Run this code at console of numbro website:

numbro(1234000).format({
  output: "number",
  forceAverage: "million",
  abbreviations: {
        thousand: "K",
        million: "M",
        billion: "B",
        trillion: "T"
    },
})

// output: 1m

Expect Behavior

The outputs should be 1M

Description

According to the description of the code:

numbro/src/validating.js

Line 154 in cac2055

abbreviations: validAbbreviations,

There is an option named abbreviations which can be used in config abbr of thousand | million | ....

Debug

Within the formatting.js#formatNumber() function，the providedFormat.abbreviations was ignored to computed the average abbreviation. ONLY globalState.currentAbbreviations was used.

Solution

// maybe this will work...
abbreviations: Object.assign({}, state.currentAbbreviations(), providedFormat.abbreviations),

[BenjaminVanRyseghem]

Thanks for the report. I'll look into it as soon as I can 😄