Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Split the linter plugin to multiple plugins #1487

Open
7 tasks
kpanot opened this issue Mar 13, 2024 · 1 comment · May be fixed by #2354
Open
7 tasks

[Feature]: Split the linter plugin to multiple plugins #1487

kpanot opened this issue Mar 13, 2024 · 1 comment · May be fixed by #2354
Labels
enhancement New feature or request priority:medium Technical Improvment Technical Improvement of an existing feature

Comments

@kpanot
Copy link
Contributor

kpanot commented Mar 13, 2024

Context

Today Otter exposes one single plugin with rules dedicated to different features.
In the current setup, all the Otter Linter rules are per default activated which require additional dependency to an application that would not use it in its own code.

Proposal

  • Split the code of the plugin to the dedicated package
  • Expose the linter plugin and it's recommended configuration as subentries
  • The additional required dependencies should be peer optional dependencies
  • A package to share helpers may need to be created
  • The @o3r/eslint-config-otter package should setup the rules of the modules provided by the application (using import() ?).
  • An ngUpdate should be provided to @o3r/eslint-plugin to migrate to the import of the different packages
  • @o3r/eslint-plugin should be deprecated
@kpanot kpanot added enhancement New feature or request Technical Improvment Technical Improvement of an existing feature labels Mar 13, 2024
@pginoux-1A
Copy link
Contributor

We could check depending on the package installed which rules applied (today we have the configuration).
We could also have 1 plugin / module as a package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Technical Improvment Technical Improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants